android: getEngines now returns voice label#584
Open
zywek123 wants to merge 1 commit intodlutton:masterfrom
Open
android: getEngines now returns voice label#584zywek123 wants to merge 1 commit intodlutton:masterfrom
zywek123 wants to merge 1 commit intodlutton:masterfrom
Conversation
dlutton
approved these changes
May 28, 2025
Owner
dlutton
left a comment
dlutton
left a comment
There was a problem hiding this comment.
LGTM (looks like a breaking change though)
Author
|
@dlutton Should i provide an example how to properly change the engine and update an example app? Or modify setEngine function to accept <String, String. as a parameter? |
Owner
|
@zywek123 yes an update to the README would be helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In apps like @voice aloud reader, when choosing a voice, You has proper voice labels.
I've modified getEngines function to provide labels too.
If it will be necessary, I can modify getDefaultEngine function to provide an engine label.